Skip to content

Conversation

erikhfj
Copy link
Member

@erikhfj erikhfj commented Oct 15, 2026

Summary

Documentation only, for #48. Two files.

README.md was still describing M1, and one line was simply wrong: it said client/ renders mock data. The mock-data search interface never landed. The client is still the skeleton and #9 wires it straight to GraphQL.

  • Current milestone moved to M2
  • New "Where the code is" table: implemented vs. planned
  • Local setup for server/ as well as the client: DATABASE_URL, migrate, optional seed
  • Server commands added to the command table
  • Infrastructure names crate-api.service, what it runs, and what CI actually deploys
  • The M1 row now lists what M1 delivered, not mock data that did not land
  • Sort modes corrected to four, checked against AlbumSort in schema.graphql

docs/AI-USAGE.md gets the eight erikhfj rows missing since 1 October:

Date Work
2026-10-07 #10 User type and the X-User-Id contract
2026-10-09 #8 VM runbook, hand copy to real git clone
2026-10-10 #13 facet-count trade-off
2026-10-10 #43 source-map-js override
2026-10-10 #44 deploy gap traced and filed
2026-10-12 #10 displayName wording corrected
2026-10-15 #45 review fixes
2026-10-15 this pass

The displayName row is the kind the log intro calls out as most important. The tool drafted a claim that displayName stops one user writing as another. It does not, and robertky caught it. That is recorded rather than quietly fixed.

Notes for the others

Per #48, each member documents their own AI usage, so only erikhfj rows were added. If you have work since 1 October that is not in the table, please add it here before this merges.

robertky's row from #46 was sitting at the end of the table out of date order. It is now with the rest of 9 October and its relative position within that day is unchanged.

Testing

  • pnpm format:check && pnpm lint && pnpm typecheck && pnpm test - all pass
  • Checked every factual claim in the README against the repository: AlbumSort has four values, searchAlbums is the only query with a resolver (server/src/resolvers.ts), client/src/App.tsx is the skeleton it says it is
  • No em-dashes in either file
  • No conflict markers left from rebasing over the rows added on main meanwhile

Still open from #48

README was still describing M1, and one line was simply wrong: it said
`client/` renders mock data. The mock-data search interface never landed,
the client is still the skeleton and #9 wires it straight to GraphQL.

- Current milestone moved to M2
- New "Where the code is" table, implemented vs. planned
- Local setup for `server/` too: DATABASE_URL, migrate, optional seed
- Server commands in the command table
- Infrastructure names `crate-api.service` and what CI deploys
- M1 row now lists what M1 actually delivered, not mock data that did not
  land
- Sort modes corrected to four, checked against `AlbumSort` in the schema

AI usage log gets the eight erikhfj rows missing since 1 October: the
#10 identity contract, the #8 VM runbook and the git clone, the #13 facet
trade-off, the #43 source-map-js override, the #44 deploy gap, the
displayName correction, the #45 review fixes, and this pass.

The displayName row is the kind the log intro calls out as most
important: the tool drafted a claim that a person had to correct.

Per #48 each member documents their own usage, so only erikhfj rows were
added. robertky's row from #46 was out of date order at the end of the
table and is now with the rest of 9 October, and his relative order
within the day is unchanged.

Co-Authored-By: opencode <noreply@opencode.ai>
@erikhfj erikhfj requested a review from a team as a code owner October 15, 2026 17:14
erikhfj and others added 2 commits October 15, 2026 13:03
#46 merged while this was open, so two README claims were behind.

The "Implemented" list now names the schema that actually exists: tracks,
simulated users, reviews and crate items, with trigger-maintained full-text
search over titles at weight A and artist names at weight B. Checked
against set_album_search_vector() in migration 0001 rather than the PR
description.

Also warns that db:seed is a reset command, not a loader. It replaces the
catalog and, through foreign-key cascades, deletes the reviews and crate
items hanging off it. docs/VM-setup.md gained that warning from #46 and
the README was quietly understating it.

Not changed: "searchAlbums is the only query with a resolver" is still
true after #46, which was schema only and added no resolvers.

Co-Authored-By: opencode <noreply@opencode.ai>
Fold #46 into the README and add db:migrate to the #45 deploy, plus the
DATABASE_URL reconciliation that came out of it.

Co-Authored-By: opencode <noreply@opencode.ai>
Copy link
Member

@rachelks rachelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating the README and AI log

@rachelks rachelks merged commit 634ce04 into main Oct 16, 2026
2 checks passed
@rachelks rachelks deleted the docs/48-readme-and-ai-log branch October 16, 2026 18:12
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants